[Webkit-unassigned] [Bug 51091] New: [NRWT] Rewrite current test_types/* classes completely.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51091

           Summary: [NRWT] Rewrite current test_types/* classes
                    completely.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hayato at chromium.org
                CC: dpranke at chromium.org
            Blocks: 36065


As I and Dirk disscussed in chat, it might be better to rewrite current test_types/* classes completely.

The reasons are:

1) All of the test_types/* classes are pretty kludgy at this point.
   They try to do too many things in test_type.compare_output() method, like
    - regenerate baselines.
    - copy the output around, etc..

2) The current class hieralchy does't give us significant benefits at this point.
   There are only two subclasses, TextDiff and ImageDiff. It is difficult to add new test type because compare_output() method has many side effects and doesn't have clear responsibility what subclass should implement in this method.

I think more simple approach is better than the current test_type/* approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.