[Webkit-unassigned] [Bug 51029] Would like a pre-commit hook that checks for well-formedness of .vcproj/.vsprops XML files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 14 16:25:08 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=51029
--- Comment #3 from Steve Falkenburg <sfalken at apple.com> 2010-12-14 16:25:07 PST ---
Here are some recent build fixes required after incorrect edits to WebCore.vcproj that would have been caught by an XML well-formedness check:
http://trac.webkit.org/changeset/73887/trunk/WebCore/WebCore.vcproj/WebCore.vcproj
http://trac.webkit.org/changeset/73773/trunk/WebCore/WebCore.vcproj/WebCore.vcproj
http://trac.webkit.org/changeset/72795/trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Adding this to the style checker might be an ok place to start.
This seems worse than a simple lint or style issue since these aren't stylistic problems (they're fatal errors).
Not sure where the line is between pre-commit hook and style checker. We check for tabs in pre-commit hook for example.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list