[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50635





--- Comment #25 from Dirk Pranke <dpranke at chromium.org>  2010-12-14 15:56:48 PST ---
(In reply to comment #23)
> (In reply to comment #22)
> > (From update of attachment 76533 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=76533&action=review
> > 
> > >> WebKitTools/Scripts/webkitpy/layout_tests/port/test.py:214
> > >> +        if path.find('.') != -1:
> > > 
> > > This is fine for now given that this is just for testing, but in the real webkit tree, we have the CSS2.1 directory, which we may want to add tests for in the future. Please add a FIXME to make this work for that case.
> > 
> > In particular, since the list of files and directories is fixed and small in this case, all you are doing is speeding up the check in line 224, but I doubt that produces a noticeable speedup.
> 
> I had to make this change to actually make the tests pass...
> 
> The noticeable speedup is in the real tests expectations parsing, eg. avoiding the expensive iteration over the *BIG* list of tests, when possible. :)

Oh, yeah, obviously there's a big speedup in the real parsing. I'm just surprised that you would need to make a change to test.py for the tests to pass. I'll have to look into that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.