[Webkit-unassigned] [Bug 45692] REGRESSION (r63339): Mouse cursor disappears when holding mouse button down on page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45692





--- Comment #8 from Adam Roben (aroben) <aroben at apple.com>  2010-12-14 12:45:42 PST ---
(From update of attachment 76556)
View in context: https://bugs.webkit.org/attachment.cgi?id=76556&action=review

>> WebKit/win/WebCoreSupport/WebChromeClient.cpp:810
>> +        ::SetCursor(platformCursor);
> 
> Is it useful to assert that the cursor is non-null here?

I don't think so. We already null-checked platformCursor on line 797 above.

>> WebKit/win/WebCoreSupport/WebChromeClient.cpp:812
>> +    setLastSetCursorToCurrentCursor();
> 
> Is there a reason this wasn't called before/was it called from somewhere else before this patch?

Prior to this patch, m_webView->setLastCursor was called. setLastSetCursorToCurrentCursor() calls that same function, but passes it the result of ::GetCursor(), which should now return the cursor we (or the UI delegate) just passed to ::SetCursor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.