[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50635





--- Comment #22 from Dirk Pranke <dpranke at chromium.org>  2010-12-14 12:22:55 PST ---
(From update of attachment 76533)
View in context: https://bugs.webkit.org/attachment.cgi?id=76533&action=review

>> WebKitTools/Scripts/webkitpy/layout_tests/port/test.py:214
>> +        if path.find('.') != -1:
> 
> This is fine for now given that this is just for testing, but in the real webkit tree, we have the CSS2.1 directory, which we may want to add tests for in the future. Please add a FIXME to make this work for that case.

In particular, since the list of files and directories is fixed and small in this case, all you are doing is speeding up the check in line 224, but I doubt that produces a noticeable speedup.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.