[Webkit-unassigned] [Bug 50621] Implement text-combine rendering code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50621





--- Comment #19 from Dave Hyatt <hyatt at apple.com>  2010-12-14 11:35:37 PST ---
I think what you should be doing here is just pretending like compression could be specified in CSS and modeling it that way.   Think of it as being like style (italic) or weight (bold).  Imagine a hypothetical font-compression property where you could specify the values (normal, 1/2, 1/3, 1/4), and pretend like you're implementing it (minus the actual property definition itself).

Adding compression to the font description is good.  Keep that, and then make compression something you can then select fonts on, so that means making it part of the FontPlatformData, etc.

Don't make compression part of the derived data.  (I still think the derived data idea is a good one, even with just the small caps and broken ideographic font members, but it could be a separate patch.)  Derived data is about selectively falling back based off characters, and I don't think that's what you need here.  I think compression is simpler and can be more like style or weight (we might even be able to synthesize it like we can with bold/italic).

Once you do that, you have the ability to ask for any compressed font from the cache.  I think you could then make a RenderCombinedText subclass that does the font adjustment by asking for the right font and setting it on the RenderStyle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.