[Webkit-unassigned] [Bug 50971] Combine setShadowRoot and clearShadowRoot into a simpler API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50971





--- Comment #3 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2010-12-14 11:08:40 PST ---
(From update of attachment 76446)
View in context: https://bugs.webkit.org/attachment.cgi?id=76446&action=review

Thanks for the review! New patch coming up.

>> WebCore/dom/Element.cpp:1093
>> +    } else if (!newRoot)
> 
> I think this else is wrong.

You're right! I don't know what I've been drinking last night.

>> WebCore/dom/Element.cpp:1097
>> +    newRoot->setShadowHost(this);
> 
> If hasRareData was true and newRoot is a null pointer, then we’ll dereference the null pointer here.

Yup. My "else" above was enabling this to happen.

>> WebCore/dom/Node.h:220
>> +    void setShadowHost(Element*);
> 
> Why are you making these member functions public? Seems unrelated to the rest of the patch?

Because I need to use setShadowHost() from Element::setShadowRoot() and thought I might as well bring shadowHost() out with it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.