[Webkit-unassigned] [Bug 49904] [GTK] Add a signal to allow applications to handle its own context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49904





--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com>  2010-12-14 09:07:15 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > The context menu signal + setting is already far too complex. I'm not a fan of adding another signal entirely. This patch is very close to handling every use case we need for context menus. 
> > 
> > close? which use case is not handled? I see 4 uses cases:
> > 
> 
> He means it's very close to handling all cases only with this signal.

I think both signals are complementary to cover different test cases. 

> Obviously all possible cases are already handled with all the signals + the setting.

Ok, sorry, I misunderstood it.

> FWIW I'm not really a fan of the GList API and I think a setting makes things easier for some common cases, but I guess that's up for debate.

Passing a list of items, using a GList or any other container, would mean the client would have to iterate the list comparing every item in the list with every item he wanted to add to know wehter to add it ro not, assuming we know how to compare the items which is another problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.