[Webkit-unassigned] [Bug 50762] [EFL] ContextMenu implementation is broken

Tue Dec 14 07:53:02 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=50762

Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76537|                            |review?, commit-queue-
               Flag|                            |

--- Comment #1 from Leandro Pereira <leandro at profusion.mobi>  2010-12-14 07:53:01 PST ---
Created an attachment (id=76537)
 --> (https://bugs.webkit.org/attachment.cgi?id=76537&action=review)
Possible solution

The attached patch is a possible solution.

The reason it does not have a ChangeLog entry is that I'd like some opinion on it before going further. The EFL port menu implementation is a bit tricky since we delegate menu creation to the browser (mobile and desktop have different UIs and needs different widgets) -- thus we can't call EFL directly from our WebCore classes.

Although this patch is filled with #ifdefs, EFL tree is currently red and we're out of time this year to move to the new context menu API. Is this patch acceptable, even if temporarily while we work on updating the port to use the new API?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.