[Webkit-unassigned] [Bug 27048] [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27048





--- Comment #11 from Mario Sanchez Prada <msanchez at igalia.com>  2010-12-14 07:28:05 PST ---
(In reply to comment #10)
> (From update of attachment 76411 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76411&action=review
> 
> > WebCore/editing/gtk/SelectionControllerGtk.cpp:43
> > +static void maybeEmitTextFocusChange(PassRefPtr<AccessibilityObject> prpObject)
> 
> Can you use a full name instead of 'prpObject' when landing? Thanks.

I used that prefix according to the Guidelines written in here:

http://webkit.org/coding/RefPtr.html > Guidelines > Function arguments

Agree it's a weird prefix, although not that weird once you know it means "PassRefPtr" :-). Other than that, it's widely used in WebCore:

dom/Node.cpp:2572:bool Node::dispatchEvent(PassRefPtr<Event> prpEvent)
dom/Node.cpp:2596:bool Node::dispatchGenericEvent(PassRefPtr<Event> prpEvent)
dom/NamedNodeMap.cpp:248:void NamedNodeMap::addAttribute(PassRefPtr<Attribute> prpAttribute)
dom/Range.cpp:919:void Range::insertNode(PassRefPtr<Node> prpNewNode, ExceptionCode& ec)
editing/CompositeEditCommand.cpp:273:void CompositeEditCommand::mergeIdenticalElements(PassRefPtr<Element> prpFirst, PassRefPtr<Element> prpSecond)
[...]

Hence, as agreed via IRC with Xan, committing the patch as it is right now...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.