[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 07:25:20 PST 2010


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #76533|review?                     |review+
               Flag|                            |

--- Comment #20 from Ojan Vafai <ojan at chromium.org>  2010-12-14 07:25:20 PST ---
(From update of attachment 76533)
View in context: https://bugs.webkit.org/attachment.cgi?id=76533&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:742
> +            result = [test for test in self._full_test_list if test.startswith(path)]

nit: I would make this an early return, then you can drop the "else:" line.

> WebKitTools/Scripts/webkitpy/layout_tests/port/test.py:214
> +        if path.find('.') != -1:

This is fine for now given that this is just for testing, but in the real webkit tree, we have the CSS2.1 directory, which we may want to add tests for in the future. Please add a FIXME to make this work for that case.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list