[Webkit-unassigned] [Bug 50820] [GTK] Port to GtkStyleContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50820





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2010-12-14 05:35:51 PST ---
(In reply to comment #2)
> Created an attachment (id=76518)
 --> (https://bugs.webkit.org/attachment.cgi?id=76518&action=review) [details]
> RenderThemeGtk2: m_themeParts and m_themePartsHaveRGBAColormap have been removed. Mozilla code uses a global static GtkThemeParts struct, hwoever, we are allocating a new structure everytime a new RenderThemeGtk instance is created, but that new struct is not used because moz_gtk_use_theme_parts() is only called the first time. So we can allocate the GtkThemeParts only once the first time, move the HaveRGBAColormap to the struct and add an accessor to gtkdrawing to get the global struct. If using heap allocation is a problem we can use a stack allocated struct in gtkdrawing. 

I've just noticed that I forgot to free the global GtkThemeParts struct in moz_gtk_shutdown(), so I can add the free there, or just use a stack allocated struct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.