[Webkit-unassigned] [Bug 51021] Add JSRegExp.h to YARR
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 14 02:44:48 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=51021
Peter Varga <pvarga at inf.u-szeged.hu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76520| |review?
Flag| |
--- Comment #1 from Peter Varga <pvarga at inf.u-szeged.hu> 2010-12-14 02:44:47 PST ---
Created an attachment (id=76520)
--> (https://bugs.webkit.org/attachment.cgi?id=76520&action=review)
proposed patch
This patch causes a style error:
JavaScriptCore/yarr/RegexCompiler.cpp:29: Found other header before a header this file implements.
Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
The reason is the RegexCompiler.h contained just the decleration of the compileRegex() function. I move it to the
new header: JSRegExp.h. I don't want to move any line from the RegexCompiler.cpp to the RegexCompiler.h
therefore it became unnecessary.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list