[Webkit-unassigned] [Bug 50971] Combine setShadowHost and clearShadowHost into a simpler API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50971


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76446|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-12-13 22:12:01 PST ---
(From update of attachment 76446)
View in context: https://bugs.webkit.org/attachment.cgi?id=76446&action=review

> WebCore/ChangeLog:5
> +        Combine setShadowHost and clearShadowHost into a simpler API

You mean setShadowRoot and clearShadowRoot, right?

> WebCore/dom/Element.cpp:1093
> +    } else if (!newRoot)

I think this else is wrong.

> WebCore/dom/Element.cpp:1097
> +    newRoot->setShadowHost(this);

If hasRareData was true and newRoot is a null pointer, then we’ll dereference the null pointer here.

> WebCore/dom/Node.h:220
> +    Element* shadowHost() const;
> +    void setShadowHost(Element*);

Why are you making these member functions public? Seems unrelated to the rest of the patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.