[Webkit-unassigned] [Bug 50098] New webkit-patch rebaseline2 command.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 22:10:51 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50098





--- Comment #47 from James Kozianski <koz at chromium.org>  2010-12-13 22:10:50 PST ---
(In reply to comment #46)
> > Apologies for the large patch here. I'd be glad to talk about it but unfortunately I'm in Sydney, so talking in person would be difficult. Perhaps I should try breaking the patch up and we can discuss it as we get through it all?
> 
> I think that's a great idea.  Can you upload the different pieces in separate bugs that block this bug?  I think we're at the point where we should start landing this patch in pieces.

Yep, will do. I've split off the first patch into bug 50901.

> 
> > This patch could be decomposed into these parts:
> > 
> > - The random utility classes (DirAsZip, RemoteZip together, IndentedLogger in a separate one?)
> 
> Yep.  I'd put DirAsZip and RemoteZip together but put IndentedLogger in a separate patch.  It might seem pedantic to break these things up into smaller pieces, but it's very helpful.

Oh, not at all. I can see the wisdom of having smaller patches. My original concern was that landing the overall context and direction of the script would be lost in smaller patches, but I think it's good now.

> 
> > - Introduce Result and ResultSet classes (includes changes to Buildbot to support returning ResultSets).
> 
> Yep.
> 
> > - Introduce new 'webkit-patch rebaseline2' command, which requires Bucket/BucketTree/Rebaseliner.
> 
> I'd have to look at the details, but that sounds like a reasonable plan.  Don't forget:
> 
> - Remove old rebaseline commands.  :)

Yep, will do :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list