[Webkit-unassigned] [Bug 51011] WebKit2: Need to be able to set the application name for the user agent for a WKPage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51011


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76496|review?                     |review+
               Flag|                            |




--- Comment #2 from Anders Carlsson <andersca at apple.com>  2010-12-13 21:45:43 PST ---
(From update of attachment 76496)
View in context: https://bugs.webkit.org/attachment.cgi?id=76496&action=review

Maybe we should move the user agent computation code to WebCore so that it can be shared between WebKit1 and WebKit2?

> WebKit2/UIProcess/WebPageProxy.cpp:631
> +        return;

Doesn't seem like this check is needed here.

> WebKit2/UIProcess/WebPageProxy.h:404
> +    static String standardUserAgent(const String& = String());

I think leaving out the parameter name here just leads to confusion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.