[Webkit-unassigned] [Bug 47320] [Performance] Only call sendContentResizeNotification when the scrollbar actually did change

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47320





--- Comment #16 from Ryuan Choi <ryuan.choi at samsung.com>  2010-12-13 20:08:15 PST ---
(In reply to comment #13)
> (From update of attachment 76465 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76465&action=review
> 
> > WebCore/ChangeLog:15
> > +
> 
> You have to verify that you do not break the frame flattening tests with this change. Are you running the layout tests?

Sorry.
With layout tests, I got failed. I think that I should investigate more.

(In reply to comment #14)
> (From update of attachment 76465 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76465&action=review
> 
> Also as kenneth said, Qt Gtk and Mac DRT test the flame flattening feature. Please, make sure there is no regression.
> 
> > WebCore/platform/ScrollView.cpp:102
> >  void ScrollView::setHasVerticalScrollbar(bool hasBar)
> >  {
> > -    if (hasBar && avoidScrollbarCreation())
> > +    if (hasBar)
> 
> Well, if we go for it, I would also suggest to add an assert here:
> 
> ASSERT(avoidScrollbarCreation())
> 
> That way we ensure that no one is calling setHasVerticalScrollbar() without previously calling avoidScrollbarCreation()

Sorry, This patch was wrong.
I'll prepare new patch after those testing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.