[Webkit-unassigned] [Bug 47320] [Performance] Only call sendContentResizeNotification when the scrollbar actually did change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 16:59:38 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=47320





--- Comment #14 from Antonio Gomes <tonikitoo at webkit.org>  2010-12-13 16:59:38 PST ---
(From update of attachment 76465)
View in context: https://bugs.webkit.org/attachment.cgi?id=76465&action=review

Also as kenneth said, Qt Gtk and Mac DRT test the flame flattening feature. Please, make sure there is no regression.

> WebCore/platform/ScrollView.cpp:102
>  void ScrollView::setHasVerticalScrollbar(bool hasBar)
>  {
> -    if (hasBar && avoidScrollbarCreation())
> +    if (hasBar)

Well, if we go for it, I would also suggest to add an assert here:

ASSERT(avoidScrollbarCreation())

That way we ensure that no one is calling setHasVerticalScrollbar() without previously calling avoidScrollbarCreation()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list