[Webkit-unassigned] [Bug 50758] Defer loading print stylesheets

Mon Dec 13 11:14:07 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=50758

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76406|review?                     |review+
               Flag|                            |

--- Comment #19 from Alexey Proskuryakov <ap at webkit.org>  2010-12-13 11:14:07 PST ---
(From update of attachment 76406)
View in context: https://bugs.webkit.org/attachment.cgi?id=76406&action=review

>> Please modify other project files.
> Done.

Please also update the ChangeLog.

> > Please remove this FIXME. There is no such thing as "unnecessary stylesheet".
> Stylesheets that are never used are unnecessary to load. This is major performance concern. I have bug open to fix this too.

How do we know that they are never used? The only thing we could do is block on CSSOM access and load the stylesheet on demand, but that's even worse, as that would use a synchronous load. And even that could have compatibility implications - servers heavily rely on getting exactly one request for a Web font, for example.

Please do remove the FIXME - it's not really necessary if there's a bug, and we can continue the discussion in the bug.

> > Please consider also implementing this at least for WebKit2.
> Later.

OK. Generally, we should treat WebKit2 as first class citizen now, and if I were making this patch, implementing a WebKit2 DRT hook while I was still fully in the context of this work would be easiest for me.

> LayoutTests/platform/win/Skipped:1098
> +# For https://bugs.webkit.org/show_bug.cgi?id=50758
> +# These require DRT setSerializeHTTPLoads implementation to be reliable.

As a courtesy, we try to modify other platforms' Skipped lists, too (when it's straightforward).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.