[Webkit-unassigned] [Bug 50891] [GTK] Add API to enable/disable plugins at runtime

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 10:37:38 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50891


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76325|review?                     |review+
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-12-13 10:37:38 PST ---
(From update of attachment 76325)
View in context: https://bugs.webkit.org/attachment.cgi?id=76325&action=review

Great stuff. Please fix the tiny style nits below before landing.

> WebKit/gtk/webkit/webkitwebplugin.cpp:67
> +static void webkit_web_plugin_get_property(GObject* object, guint prop_id, GValue* value, GParamSpec* pspec)

Should be propertyId and paramSpec here.

> WebKit/gtk/webkit/webkitwebplugin.cpp:80
> +static void webkit_web_plugin_set_property(GObject* object, guint prop_id, const GValue* value, GParamSpec *pspec)

Same here and the asterisk on pspec should be with GParamSpec.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list