[Webkit-unassigned] [Bug 50942] New: Move caret-browsing related layout tests out of platform/gtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50942

           Summary: Move caret-browsing related layout tests out of
                    platform/gtk
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: msanchez at igalia.com
                CC: xan.lopez at gmail.com, tonikitoo at webkit.org,
                    mrobinson at webkit.org
        Depends on: 25333,27048


As it was pointed out in comment #43 for bug 25526 (https://bugs.webkit.org/show_bug.cgi?id=25526#c43), and properly tracked down through bug 50536, GTK is about to stop being the only platform implementing caret browsing mode (well, Mac has the VO cursor, which is a similar thing but a different implementation) since Qt is going to support it too. Hence, it would be interesting to have all those Layout tests out of platform/gtk, where they normally are nowadays.

Current proposal to fix this bug would therefore be to do the following:

  * Move all the caret-browsing related Layout tests out from platform/gtk to editing/caret-browsing. (I think this would be a good place to put them all, but if somebody has a better suggestion it would be awesome to share it)

  * Put the moved tests in the Skipped files for all platforms but GTK, which would be the only one initially passing all of them.

  * Further tests related to caret-browsing should be placed under that path, and initially skipped in all platforms but the one adding them.


As there's currently a couple of patches pending on review which would add these kind of tests under platform/gtk (see bug 27048 and bug 25533), my personal proposal it's to keep the current policy of adding them as platform specific, and after both of them get integrated, providing a patch to fix this bug but moving all the tests together to the right place. That's why I'm settting this bug as dependant on those.

This way we have the double benefit of not messing things up in patches currently on review while, at the same time, leaving room to think about this bug and the proposal itself (such as if the right destination path should be editing/caret-browsing, or somewhere else).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.