[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 10:02:58 PST 2010


--- Comment #14 from Dirk Pranke <dpranke at chromium.org>  2010-12-13 10:02:57 PST ---
Nice catch! I knew there had to be a reason chromium's parsing was getting quadratically slower but I hadn't had the time to look into it.

The change basically looks fine but I would make one minor modification. We already know whether the path points to a directory or a file from the check on line 732, so you can merge the two if blocks together and save yourself an extra os call.

Seems like we could probably still speed up the directory/category branch of the loop by switching to a more tree-based storage mechanism for the file list, or by revamping the calling code to do a merge join instead of a nested-loop join but it's probably not worth it for now, so I would leave the code as is since it's a lot more obviously correct. You could consider adding a #FIXME that there's an opportunity for a speed up here.

As far as using a regexp goes, I'd be more than a little surprised if a regexp was faster than a string prefix match.

-- Dirk

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list