[Webkit-unassigned] [Bug 27048] [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 13 03:44:59 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=27048
Xan Lopez <xan.lopez at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #74224|review? |review-
Flag| |
--- Comment #8 from Xan Lopez <xan.lopez at gmail.com> 2010-12-13 03:44:59 PST ---
(From update of attachment 74224)
View in context: https://bugs.webkit.org/attachment.cgi?id=74224&action=review
Mostly looks good to me, just have some doubts/comments, see below.
> WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:506
> + Settings* settings = coreObject->document()->frame()->settings();
Some of those can be in some situations NULL. At the very least frame(). If this function can never be called in those cases then you should ASSERT.
> WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:521
> + return !selectionBelongsToObject(coreObject, selection) || selection.isNone() ? 0 : 1;
How is this grouping exactly? It's a quite confusing statement.
> WebCore/editing/gtk/SelectionControllerGtk.cpp:48
> + static RefPtr<AccessibilityObject> oldObject = 0;
Mmm, I think you want to use DEFINE_STATIC_LOCAL here?
> WebCore/editing/gtk/SelectionControllerGtk.cpp:82
> + // Reset lastFocuseNode and return for no valid selections.
I don't see that reset happening?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list