[Webkit-unassigned] [Bug 50617] ValidityState's exposed functions should check if willValidate() is true before all

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50617


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76362|review?                     |review-
               Flag|                            |




--- Comment #25 from Kent Tamura <tkent at chromium.org>  2010-12-13 03:21:40 PST ---
(From update of attachment 76362)
View in context: https://bugs.webkit.org/attachment.cgi?id=76362&action=review

> LayoutTests/fast/css/pseudo-required-optional-005.html:28
> +shouldBeFalse('isGreenFor("submit")');

This is wrong.  Submit button doesn't support "required" attribute.  So ":optional" class should be applied to the element.

Also, the name "isGreenFor" is not good.  "isOptional" would be helpful.

> LayoutTests/fast/css/pseudo-valid-unapplied.html:69
> +shouldBe('getBackgroundColor("input-submit")', "invalidColor");
> +shouldBe('getBackgroundColor("input-image")', "normalColor");
> +shouldBe('getBackgroundColor("fieldset")', "normalColor");
> +shouldBe('getBackgroundColor("object")', "normalColor");
> +shouldBe('getBackgroundColor("button")', "invalidColor");

This test file is for "unapplied" cases.  Input-submit and button should be moved to another test file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.