[Webkit-unassigned] [Bug 50888] build-webkit --minimal --enable-video doesn't enable video

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50888


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76321|review?                     |review-
               Flag|                            |




--- Comment #3 from Csaba Osztrogonac <ossy at webkit.org>  2010-12-13 03:15:54 PST ---
(From update of attachment 76321)
It doesn't work, because there isn't --enable-video option in build-webkit script.
You can use --video to enable and --no-video to disable video support.

This code sets the default value or 0 if you passed --minimal option :
...
# Initialize values from defaults
foreach (@features) {
    ${$_->{value}} = ($_->{default} && !$minimal) || 0;
}
...

But the script processes the command line arguments later:
...
# Build usage text and options list from features
foreach (@features) {
    my $opt = sprintf("%-35s", "  --[no-]$_->{option}");
    $usage .= "$opt $_->{desc} (default: $_->{default})\n";
    $options{"$_->{option}!"} = $_->{value};
}
...

So "build-webkit --minimal --video" will work for you and it isn't a bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.