[Webkit-unassigned] [Bug 49658] [GTK] Simplify context-menu handling code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49658


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76364|                            |review?, commit-queue?
               Flag|                            |




--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com>  2010-12-13 03:00:27 PST ---
Created an attachment (id=76364)
 --> (https://bugs.webkit.org/attachment.cgi?id=76364&action=review)
New patch rebased to current master

Rebased to current git master and fixing the crash in editing/selection/empty-cell-right-click.html. It also improves the code that connects the activate signal for the menu items. gtk_container_get_children() uses gtk_container_foreach() to build the list of items, so we are iterating twice, one to build the list and another one to connect the signal. Using gtk_container_foreach() directly we iterate only once and we avoid creating/destroying the GList. It also makes easier to connect the acivate signal for submenu items.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.