[Webkit-unassigned] [Bug 47746] Respect charset in handleDataURL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 00:37:18 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=47746


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74968|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Eric Seidel <eric at webkit.org>  2010-12-13 00:37:19 PST ---
(From update of attachment 74968)
The ChangeLog needs to mention that this fixes 130 layout tests, and for which port.  Otherwise the change looks fine.

(Every change requires a test, or explanation of why testing is impossible.)  In this case, you have many tests, you just didn't explain that you're fixing them (which is importnat both for reviewers and folks looking back through teh svn history).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list