[Webkit-unassigned] [Bug 46283] Allow CSS animations to run at more than 40FPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46283





--- Comment #12 from Noam Rosenthal <noam.rosenthal at nokia.com>  2010-12-12 09:49:42 PST ---
(In reply to comment #11)
> (From update of attachment 75616 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75616&action=review
> 
> > WebCore/page/animation/AnimationController.cpp:46
> > +double AnimationController::s_animationTimerDelay = 0.025;
> 
> Please document what this value means.  It's not even clear what the units are (although I'm assuming seconds).
> 
> > WebKit/qt/Api/qgraphicswebview.cpp:252
> > +    Settings::setAnimationTimerDelay(0.0167);
> 
> Please make it clearer what this value means.


This is a webkit-wide problem that this patch didn't create; (In reply to comment #11)
> (From update of attachment 75616 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75616&action=review
> 
> > WebCore/page/animation/AnimationController.cpp:46
> > +double AnimationController::s_animationTimerDelay = 0.025;
> 
> Please document what this value means.  It's not even clear what the units are (although I'm assuming seconds).
> 
> > WebKit/qt/Api/qgraphicswebview.cpp:252
> > +    Settings::setAnimationTimerDelay(0.0167);
> 
> Please make it clearer what this value means.

This is a webkit-wide problem that this patch didn't create; Adding the word "seconds" everywhere, which I agree would make things clearer, would make this the only place in the codebase where such notion exists... It's easy for me to change this patch to include 'Seconds', but should we go for clarity or consistency?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.