[Webkit-unassigned] [Bug 50892] [Qt][WK2] Crash in WebPage constructor.

Sun Dec 12 07:13:45 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=50892

Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76326|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #2 from Andreas Kling <kling at webkit.org>  2010-12-12 07:13:45 PST ---
(From update of attachment 76326)
View in context: https://bugs.webkit.org/attachment.cgi?id=76326&action=review

LGTM, except one small and one big thing:

> WebKit2/WebProcess/qt/WebProcessQt.cpp:47
> +    // Disable runtime enabled features that has no WebKit2 implementation yet.

s/has/have/

> WebKit2/WebProcess/qt/WebProcessQt.cpp:53
> +    WebCore::RntimeEnabledFeatures::setSpeechInputEnabled(false);

s/Rntime/Runtime/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.