[Webkit-unassigned] [Bug 50885] [GTK] remove old data: URI handler, fix the SoupRequest-based one

Sun Dec 12 03:19:42 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=50885

Dan Winship <danw at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76317|                            |review?
               Flag|                            |

--- Comment #1 from Dan Winship <danw at gnome.org>  2010-12-12 03:19:42 PST ---
Created an attachment (id=76317)
 --> (https://bugs.webkit.org/attachment.cgi?id=76317&action=review)
patch to use SoupRequestData

The comment about "limitations in KURL" in the old parseDataUrl() does not appear to be relevant to the current code; the tests pass fine without lying about the text encoding.

The changes to sendRequestCallback() are needed because the code was apparently broken before; it worked for file URIs because they always had !shouldContentSniff(), but for any other kind of non-HTTP URI it would result in didReceiveResponse never being called.

The fixes to soup-request-data.c have already been committed to libsoup, but this means that if we commit both this patch and bug 50675 then we need updated libsoup packages on the bots, or else we'll have to temporarily skip a few tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.