[Webkit-unassigned] [Bug 50882] New: FilterEffect::effectContext() can leak m_effectBuffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50882

           Summary: FilterEffect::effectContext() can leak m_effectBuffer
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.fraser at apple.com
                CC: zimmermann at kde.org, krit at webkit.org,
                    zherczeg at webkit.org


m_effectBuffer is allocated each time FilterEffect::effectContext() is called. Adding this assertion:


diff --git a/WebCore/platform/graphics/filters/FilterEffect.cpp b/WebCore/platform/graphics/filters/FilterEffect.cpp
index c228731..3f8f099 100644
--- a/WebCore/platform/graphics/filters/FilterEffect.cpp
+++ b/WebCore/platform/graphics/filters/FilterEffect.cpp
@@ -77,6 +77,8 @@ GraphicsContext* FilterEffect::effectContext()
     determineAbsolutePaintRect();
     if (m_absolutePaintRect.isEmpty())
         return 0;
+
+    ASSERT(!m_effectBuffer);
     m_effectBuffer = ImageBuffer::create(m_absolutePaintRect.size(), ColorSpaceLinearRGB);
     if (!m_effectBuffer)
         return 0;

shows that this indeed happens for at least one layout test:

svg/filters/feBlend-invalid-mode.xhtml -> crashed
ASSERTION FAILED: !m_effectBuffer

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.