[Webkit-unassigned] [Bug 50082] [Qt] Use QNetworkAccessManager zerocopy feature from QNetworkReplyHandler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50082


Holger Freyther <zecke at selfish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zecke at selfish.org




--- Comment #10 from Holger Freyther <zecke at selfish.org>  2010-12-11 07:21:37 PST ---
(In reply to comment #9)
> (From update of attachment 75383 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75383&action=review
> 
> > WebCore/WebCore.gypi:3144
> > +            'platform/qt/QByteBlock.cpp',
> > +            'platform/qt/QByteBlock.h',
> 
> Why is this called QByteBlock? ByteBlockQt seems more in line what we have elsewhere

I am sorry that we always nitpick so much in WebKit. I have to admit that both names have issues. ByteBlockQt indicate that it is some generic interface and this is the Qt specific part and QByteBlock has the danger of clashing with future versions of Qt.  :}

I think for now you can remove the 'capacity' call as no one is calling it?

I also have some questions. So QNetworkAccessManager will internally start changing the QSharedDataPointer<char>? Does this work with realloc? Somehow I would assume to see something like a QList<QByteArray> but I don't. So Qt will still re-alloc internally?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.