[Webkit-unassigned] [Bug 49294] [Web Timing] Zero out some values on cross-origin redirects
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 10 17:55:40 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=49294
--- Comment #4 from James Simonsen <simonjam at chromium.org> 2010-12-10 17:55:40 PST ---
(In reply to comment #2)
> (From update of attachment 74612 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74612&action=review
>
> Looks fine from a SecurityOrigin point-of-view. I'll let someone who knows WebPeformance give the real r+.
>
> > WebCore/loader/MainResourceLoader.cpp:175
> > + RefPtr<SecurityOrigin> securityOrigin(SecurityOrigin::create(newRequest.url()));
>
> We usually use the = form of the constructor.
>
> > WebCore/loader/MainResourceLoader.cpp:176
> > + if (!securityOrigin->canRequest(redirectResponse.url()))
>
> Interesting. At first I thought this was backwards, but then I realized that it was correct. Maybe add a comment explaining the ordering so we're not confused in the future?
Addressed both of these.
Tony, would you mind taking a look?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list