[Webkit-unassigned] [Bug 49345] [Chromium] Add a basic GestureManager to Chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 16:38:27 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49345





--- Comment #13 from Robert Kroeger <rjkroege at chromium.org>  2010-12-10 16:38:26 PST ---
(In reply to comment #7)
> (From update of attachment 75402 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75402&action=review
> 
> > WebCore/platform/qt/PlatformTouchEventQt.cpp:45
> > +    m_timestamp = 0;
> 
> Wouldn't it make sense to set timestamp to WTF::currentTime() instead? This way it could be used with your algoritms of GestureManager.

yes. fixed.

> 
> 
> I like the patch quite a bit, but I am concerned about platform compatibility.

Thanks.

My premise is that touch events, if not handled by the page explicitly, are converted into synthetic events handled by EventSender. Consequently, having a GestureManager "near" the EventSender seemed logical.

> 
> What about forwarding the gestures to the ChromeClient and letting the port decide how to handle the result?
> I think about features like kinetic scrolling, and zoom behavior which depends on the platform.

This is an excellent suggestion. However, I think that the basic framework here does not preclude your suggestion. I had imagined extending the GestureManager via sub-classes in a future patch. (You will note that a number of popular gestures are not admitted here.) It would make sense to permit the platform layer to provide platform-specific GestureManager extensions. In particular, the framework here permits a future platform-specific implementation to register arbitrary additional edge functions with minimal modifications here. (fingers crossed.)

> 
> I am also a bit concerned about putting behavior here when the platform already provide gesture recognition. Windows 7 for example has precise timing for gestures (WM_GESTURE messages), and users get used to the platform recognizer. By giving other timing specifically for WebKit, the engine will be less integrated in the platform.

The goal of this patch was to provide a basic framework that would be used on platforms that do not provide a gesture management system (as like double-click on some cases.) I'd like to defer some sort of platform delegation scheme to a follow-on CL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list