[Webkit-unassigned] [Bug 45870] [reviewtool] should always show overall comments text box

Fri Dec 10 16:23:40 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=45870

--- Comment #13 from Adam Barth <abarth at webkit.org>  2010-12-10 16:23:40 PST ---
(In reply to comment #12)
> I don't like the toolbar being large like that for people who use the overall comments box. There's not much advantage of it taking up the whole width of the window. You rarely type lines that long.

That's true.  We could shrink it down horizontally to something more reasonable.

> Is your issue with the current version the amount of whitespace in the middle?

My issue is more the visual flow.  If you trace the path you expect users to follow with their eyes, you want the path to be as smooth as possible (and ideally top-to-bottom or left-to-right).  With the placement you've got, the trace has to go back and forth a bunch of times.

That points to putting the comment box above the publish button so the visual flow is top-to-bottom, which is why I tried to show it appearing above the button.  Another option is to move the buttons to the right so the flow is left-to-right with comment box => bubbles => publish.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.