[Webkit-unassigned] [Bug 50698] [GTK] Split webkitprivate.{cpp, h} in more manageable chunks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50698


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76218|review?                     |review+
               Flag|                            |




--- Comment #18 from Martin Robinson <mrobinson at webkit.org>  2010-12-10 15:32:25 PST ---
(From update of attachment 76218)
View in context: https://bugs.webkit.org/attachment.cgi?id=76218&action=review

Yay! Please fix the small nits before landing.

> WebKit/gtk/webkit/webkitdownloadprivate.h:33
> +void
> +webkit_download_set_suggested_filename(WebKitDownload*, const gchar* suggestedFilename);

This should probably be one line here.

> WebKit/gtk/webkit/webkitwebnavigationactionprivate.h:31
> +WebKitWebNavigationReason kit(WebCore::NavigationType type);
> +WebCore::NavigationType core(WebKitWebNavigationReason reason);

I think you can delete these variable names.

> WebKit/gtk/webkit/webkitwebresourceprivate.h:46
> +WebKitWebResource*
> +webkit_web_resource_new_with_core_resource(PassRefPtr<WebCore::ArchiveResource>);
> +
> +void
> +webkit_web_resource_init_with_core_resource(WebKitWebResource*, PassRefPtr<WebCore::ArchiveResource>);

I think maybe no extra newlines here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.