[Webkit-unassigned] [Bug 49345] [Chromium] Add a basic GestureManager to Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49345





--- Comment #7 from Benjamin Poulain <benjamin.poulain at nokia.com>  2010-12-10 14:44:10 PST ---
(From update of attachment 75402)
View in context: https://bugs.webkit.org/attachment.cgi?id=75402&action=review

> WebCore/platform/qt/PlatformTouchEventQt.cpp:45
> +    m_timestamp = 0;

Wouldn't it make sense to set timestamp to WTF::currentTime() instead? This way it could be used with your algoritms of GestureManager.


I like the patch quite a bit, but I am concerned about platform compatibility.

What about forwarding the gestures to the ChromeClient and letting the port decide how to handle the result?
I think about features like kinetic scrolling, and zoom behavior which depends on the platform.

I am also a bit concerned about putting behavior here when the platform already provide gesture recognition. Windows 7 for example has precise timing for gestures (WM_GESTURE messages), and users get used to the platform recognizer. By giving other timing specifically for WebKit, the engine will be less integrated in the platform.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.