[Webkit-unassigned] [Bug 49294] [Web Timing] Zero out some values on cross-origin redirects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49294





--- Comment #2 from Adam Barth <abarth at webkit.org>  2010-12-10 13:13:08 PST ---
(From update of attachment 74612)
View in context: https://bugs.webkit.org/attachment.cgi?id=74612&action=review

Looks fine from a SecurityOrigin point-of-view.  I'll let someone who knows WebPeformance give the real r+.

> WebCore/loader/MainResourceLoader.cpp:175
> +        RefPtr<SecurityOrigin> securityOrigin(SecurityOrigin::create(newRequest.url()));

We usually use the = form of the constructor.

> WebCore/loader/MainResourceLoader.cpp:176
> +        if (!securityOrigin->canRequest(redirectResponse.url()))

Interesting.  At first I thought this was backwards, but then I realized that it was correct.  Maybe add a comment explaining the ordering so we're not confused in the future?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.