[Webkit-unassigned] [Bug 50814] [GTK] AX: implement isEnabled in DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 07:38:03 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50814


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76195|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-12-10 07:38:03 PST ---
(From update of attachment 76195)
View in context: https://bugs.webkit.org/attachment.cgi?id=76195&action=review

Nice patch! Please incorporate the small cleanup suggested below before landing.

> WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:382
> +    bool result = static_cast<bool>(atk_state_set_contains_state(stateSet.get(), stateType));
> +
> +    return result;

This can just be: return atk_state_set_contains_state(stateSet.get(), stateType)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list