[Webkit-unassigned] [Bug 49438] Add LayoutTests to test high accuracy mode in Geolocation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49438





--- Comment #2 from Steve Block <steveblock at google.com>  2010-12-10 06:02:04 PST ---
(From update of attachment 76085)
View in context: https://bugs.webkit.org/attachment.cgi?id=76085&action=review

I'm not sure how useful it is to add this test. The test code is rather subtle, yet all we're really testing is that a boolean flag is successfully passed to the client/service. Would it be better to add a layoutTestController.getGeolocationClientState() method which returns {idle,lowAccuracy,highAccuracy} so we can test this directly? That would also allow us to more easily write more interesting tests for the multiplexing of multiple requests to a single client in GeolocationController.

> WebKit/chromium/public/WebGeolocationClientMock.h:52
> +    WEBKIT_API void setPositions(double lowAccuracyLatitude, double lowAccuracyLongitude, double lowAccuracyAccuracy, double highAccuracyLatitude, double highAccuracyLongitude, double highAccuracyAccuracy);

I think you should do this in the non-client-based mock too.

> WebKitTools/DumpRenderTree/LayoutTestController.h:98
> +    void setMockGeolocationPositions(double lowAccuracyLatitude, double lowAccuracyLongitude, double lowAccuracyAccuracy,

This name might be a little confusing. Maybe it's better to make this setMockGeolocationPositionHighAccuracy(lat, lng, acc) - the position is used preferentially to the regular mock position when in high accuracy mode and when available.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.