[Webkit-unassigned] [Bug 33336] webkit-patch rollout should be able to do multi-revision rollouts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33336





--- Comment #10 from Gabor Rapcsanyi <rgabor at inf.u-szeged.hu>  2010-12-10 05:45:35 PST ---
(In reply to comment #8)
> (From update of attachment 76028 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76028&action=review
> 
> Have you run test-webkitpy?  Have you don a real rollout with this yet? (You can do that by having your changes in one webkit checkout and operating on a differnet one.  webkit-patch is smart enough to operate on the cwd while pulling its .py files from paths relative to it's __file__ location.
> 

Yes I tested it and all unit tests passed and also I created some rollout patches locally and it worked.

> > WebKitTools/Scripts/webkitpy/common/checkout/changelog.py:157
> > +        for revision in revision_list:
> 
> We have to be careful when passing lists as strings count as lists.  If there is any chance someone might pass a string for the revision_list it will do strange things.
> 

The update_for_revert method will always get a revision_list from PrepareChangeLogForRevert so it can't happen.

> > WebKitTools/Scripts/webkitpy/tool/commands/download_unittest.py:65
> > +        state = command._prepare_state(None, ["rev r122  125  123", "Reason"], None)
> 
> What's the 'rev' here?

Here I just tested whether somebody tries to give wrong (not numerical) revision numbers. But the 'r122' is maybe enough to test this and we can drop the 'rev' string.

> 
> > WebKitTools/Scripts/webkitpy/tool/commands/download.py:309
> > +        # We use the earliest revision for the bug info
> > +        earliest_revision = revision_list[0]
> > +        commit_info = self._commit_info(earliest_revision)
> 
> I'm not sure we don't want to process each bug individually, but this might be ok for now.

The base conception was that all of the patches belong to one bug. If the patches belong to more bugs then we should make more than one rollout patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.