[Webkit-unassigned] [Bug 50128] [Qt][WK2] webkit2 does not compile on OS X

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50128





--- Comment #6 from Balazs Kelemen <kbalazs at webkit.org>  2010-12-10 04:37:33 PST ---
(From update of attachment 75747)
View in context: https://bugs.webkit.org/attachment.cgi?id=75747&action=review

> WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:75
> +#if defined Q_OS_UNIX
> +Q_GLOBAL_STATIC(QSet<Q_PID>, processes);

Maybe using a WTF::HashSet would be more WebKitish. Furthermore, WTF::HashSet is stored in FastMalloc memory and
I think the less we mixing the FastMalloc and the standard heap is the better.

> WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:84
> +static void cleanupProcesses()
> +{
> +    QSet<Q_PID>::ConstIterator it = processes()->begin();
> +    while (it != processes()->end()) {
> +        kill(*it, SIGINT);
> +        ++it;
> +    }
> +}

We can do it more platform independently by storing QProcess pointers and use QProcess::kill.

> WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:110
> +        processes()->remove(m_pid);
> +        m_pid = 0;

m_pid = 0 seems to be useless here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.