[Webkit-unassigned] [Bug 49798] webkit-patch build should never fail due to local commits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49798





--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-12-10 03:15:51 PST ---
I'm not sure why build even needs to clean.

Especially when --no-clean is passed:

class Build(AbstractSequencedCommand):
    name = "build"
    help_text = "Update working copy and build"
    steps = [
        steps.CleanWorkingDirectory,
        steps.Update,
        steps.Build,
    ]

class CleanWorkingDirectory(AbstractStep):
    def __init__(self, tool, options, allow_local_commits=False):
        AbstractStep.__init__(self, tool, options)
        self._allow_local_commits = allow_local_commits

    @classmethod
    def options(cls):
        return AbstractStep.options() + [
            Options.force_clean,
            Options.clean,
        ]

    def run(self, state):
        os.chdir(self._tool.scm().checkout_root)
        if not self._allow_local_commits:
            self._tool.scm().ensure_no_local_commits(self._options.force_clean)
        if self._options.clean:
            self._tool.scm().ensure_clean_working_directory(force_clean=self._options.force_clean)

We should probably have run() just return early if not self._options.clean?  I don't know when it makes sense to remove local commits when --no-clean is passed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.