[Webkit-unassigned] [Bug 50804] [chromium] Reduce canvas.toDataURL("image/jpeg") run-time cost by 10%

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50804


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76174|review?                     |review+
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2010-12-10 01:40:51 PST ---
(From update of attachment 76174)
View in context: https://bugs.webkit.org/attachment.cgi?id=76174&action=review

It's a little surprising that this unroll makes things faster, but OK.   Are you certain in the stability of your numbers?

> WebCore/platform/image-encoders/skia/JPEGImageEncoder.cpp:90
> +        if ((alpha != 0) && (alpha != 255)) {

We generally use just "alpha" instead of "alpha != 0", but it might be OK here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.