[Webkit-unassigned] [Bug 50617] ValidityState's exposed functions should check if willValidate() is true before all

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50617


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76162|review?                     |review-
               Flag|                            |




--- Comment #10 from Kent Tamura <tkent at chromium.org>  2010-12-09 23:00:12 PST ---
(From update of attachment 76162)
View in context: https://bugs.webkit.org/attachment.cgi?id=76162&action=review

The patch is good enough for r+.  However I'd like to ask splitting the patch into two:
 1. merge existing tests
 2. fix willValidate-related bugs.

> LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js:12
> +    if (disabled)
> +        input.disabled = true;
> +    else
> +        input.disabled = false;

You can write "input.disabled = !!disabled".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.