[Webkit-unassigned] [Bug 50098] New webkit-patch rebaseline2 command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50098





--- Comment #43 from James Kozianski <koz at chromium.org>  2010-12-09 21:37:37 PST ---
(In reply to comment #39)
> (From update of attachment 76120 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76120&action=review
> 
> I really feel like we're doing way too much in one patch here.  Maybe you and I should talk in person?  I'm glad that this is no longer re-inventing the wheel, but I'm not sure this is really woven into webkitpy like it should be yet.

Apologies for the large patch here. I'd be glad to talk about it but unfortunately I'm in Sydney, so talking in person would be difficult. Perhaps I should try breaking the patch up and we can discuss it as we get through it all? This patch could be decomposed into these parts:

- The random utility classes (DirAsZip, RemoteZip together, IndentedLogger in a separate one?)
- Introduce Result and ResultSet classes (includes changes to Buildbot to support returning ResultSets).
- Introduce new 'webkit-patch rebaseline2' command, which requires Bucket/BucketTree/Rebaseliner.

I'll respond to your comments below in the appropriate patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.