[Webkit-unassigned] [Bug 50788] Implement IME support for Mac in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50788





--- Comment #4 from Enrica Casucci <enrica at apple.com>  2010-12-09 19:20:21 PST ---
> > WebKit2/ChangeLog:11
> > +        to the WebProcess. These calls all have a timeout of 1 second.
> 
> Unfortunately, attributedSubstringFromRange can legitimately take a lot of time if the client asks for the whole document. AppKit has been known to do that in some cases.
> 
> So, please test behavior with large documents, especially when adding attributedSubstringFromRange.
I will, I can change the timeout for every call, and I can increase it for this particular one when implemented.

> > WebKit2/UIProcess/API/mac/PageClientImpl.mm:231
> > +    commandsList = [m_wkView _interceptKeyEvent:event.nativeEvent()
> > +                                 hasComposition:hasComposition 
> > +                                 selectionStart:selectionStart
> > +                                   selectionEnd:selectionEnd
> > +                                     underlines:underlines];
> 
> Can these be combined in a single argument with a helpful name, something like StateForTextInput? The method doesn't really need any of these, so passing them into it can confuse the reader.

I agree, the number of parameters grew while I was implementing and it is confusing now. I'll change it.

> > WebKit2/UIProcess/API/mac/WKView.mm:476
> > +    _data-> _hasMarkedText = hasComposition;
> 
> Extra space here.
I'll fix it.
Thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.