[Webkit-unassigned] [Bug 49982] Change EventHandler::dispatchMouseEvent code to use DOM traversal instead of render tree traversal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 14:51:12 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49982





--- Comment #7 from Emil A Eklund <eae at chromium.org>  2010-12-09 14:51:12 PST ---
Adam,

> > WebCore/ChangeLog:12
> > +	Walk up DOM/hosted tree rather than render tree.
>
> We can't land files with tabs in them.

My bad, fixed.


> > WebCore/page/EventHandler.cpp:1869
> >                      && m_frame->selection()->toNormalizedRange()->
> >compareNode(n, ec) == Range::NODE_INSIDE
>
> Can this run JavaScript?

As far as I can tell it can not. It does update the render tree though.


> > WebCore/page/EventHandler.cpp:1875
> > +            node = node->parentOrHostNode();
>
> Are we holding references during this walk?

No, I don't see how they could become invalidated during the execution though as no dom or js interactions take place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list