[Webkit-unassigned] [Bug 49982] Change EventHandler::dispatchMouseEvent code to use DOM traversal instead of render tree traversal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49982





--- Comment #5 from Darin Adler <darin at apple.com>  2010-12-09 14:36:27 PST ---
(From update of attachment 76122)
View in context: https://bugs.webkit.org/attachment.cgi?id=76122&action=review

>> WebCore/page/EventHandler.cpp:1875
>> +            node = node->parentOrHostNode();
> 
> Are we holding references during this walk?

Adam’s point is a good one. It’s incorrect to use the node pointer after calling JavaScript if we didn’t hold a reference to it. But that bug is not new to the new code. I can’t tell from here what is done with the node after we call break. It would be easier to read if we separated the loop searching for a mouse-focusable node from the work we do on that node.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.