[Webkit-unassigned] [Bug 49511] RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49511





--- Comment #6 from Xiaomei Ji <xji at chromium.org>  2010-12-09 11:40:32 PST ---
(From update of attachment 75041)
View in context: https://bugs.webkit.org/attachment.cgi?id=75041&action=review

>> WebCore/editing/SelectionController.cpp:285
>> +            }
> 
> I don't think we should be doing this for DirectionRight.  New code seems to make sense only for DirectionForward.
> 
> Dan & Xiaomei, could you comment on this?

Is it the other way around? the new change should only apply for DirectionRight/Left.

> WebCore/editing/SelectionController.cpp:426
>          else

you probably forgot to enclose them into "{......}"

> WebCore/editing/SelectionController.cpp:579
> +                pos = VisiblePosition(m_selection.end(), m_selection.affinity());

enclose in { }.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.